Update testcontainers version to 1.20.1 #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weaviate module contains the wait strategy.
|
Thanks for keeping version up to date @eddumelendez |
tzolov
added a commit
that referenced
this pull request
Aug 8, 2024
Due to ITs failures revert some of the WeaviateContainer changes made in #1172
|
@eddumelendez i had to revert some for the changes: 86348e4 due Action/ITs failures. |
|
@tzolov testcontainers.version is ignored unless every dependency declares the version explicitly. Currently, it takes the version from spring-boot-dependencies. LMK how to proceed, I think will be fine to apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaviate module contains the wait strategy.